vivlim
/
Kart-Public
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Prevent bad PT_TEXTCMD/PT_TEXTCMD2 textcmd[0] sizes?

This commit is contained in:
Monster Iestyn 2017-05-23 16:13:42 +01:00
parent fdfd6e1c0b
commit 9e3bdc5ee2
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/d_clisrv.c
View File

@ -3737,6 +3737,15 @@ FILESTAMP
tic_t tic = maketic;
UINT8 *textcmd;
// ignore if the textcmd size var is actually larger than it should be
if (BASEPACKETSIZE + netbuffer->u.textcmd[0] > (size_t)doomcom->datalength)
{
DEBFILE(va("GetPacket: Bad Textcmd packet size! (expected %d, actual %d)\n",
BASEPACKETSIZE + netbuffer->u.textcmd[0], doomcom->datalength));
Net_UnAcknowledgePacket(node);
break;
}
// check if tic that we are making isn't too large else we cannot send it :(
// doomcom->numslots+1 "+1" since doomcom->numslots can change within this time and sent time
j = software_MAXPACKETLENGTH