From 19d19543b7184310c2eec368a255d1e8d78cc79e Mon Sep 17 00:00:00 2001 From: mazmazz Date: Mon, 3 Dec 2018 05:37:07 -0500 Subject: [PATCH 1/3] Copy string from SDL_JoystickNameForIndex before the subsystem is shut down --- src/sdl/i_system.c | 24 +++++++++++++++++++++--- src/sdl12/i_system.c | 24 +++++++++++++++++++++--- 2 files changed, 42 insertions(+), 6 deletions(-) diff --git a/src/sdl/i_system.c b/src/sdl/i_system.c index 2b35ce8b..905bec09 100644 --- a/src/sdl/i_system.c +++ b/src/sdl/i_system.c @@ -1455,16 +1455,34 @@ INT32 I_NumJoys(void) const char *I_GetJoyName(INT32 joyindex) { - const char *joyname = "NA"; + const char *tempname = NULL; + size_t templen; + char *joyname = NULL; joyindex--; //SDL's Joystick System starts at 0, not 1 if (SDL_WasInit(SDL_INIT_JOYSTICK) == 0) { if (SDL_InitSubSystem(SDL_INIT_JOYSTICK) != -1) - joyname = SDL_JoystickNameForIndex(joyindex); + { + tempname = SDL_JoystickNameForIndex(joyindex); + if (tempname) + { + templen = strlen(tempname); + joyname = malloc(templen*sizeof(char)); + strcpy(joyname, tempname); + } + } SDL_QuitSubSystem(SDL_INIT_JOYSTICK); } else - joyname = SDL_JoystickNameForIndex(joyindex); + { + tempname = SDL_JoystickNameForIndex(joyindex); + if (tempname) + { + templen = strlen(tempname); + joyname = malloc(templen*sizeof(char)); + strcpy(joyname, tempname); + } + } return joyname; } diff --git a/src/sdl12/i_system.c b/src/sdl12/i_system.c index 8729e592..c4dd96f8 100644 --- a/src/sdl12/i_system.c +++ b/src/sdl12/i_system.c @@ -1577,16 +1577,34 @@ INT32 I_NumJoys(void) const char *I_GetJoyName(INT32 joyindex) { - const char *joyname = "NA"; + const char *tempname = NULL; + size_t templen; + char *joyname = NULL; joyindex--; //SDL's Joystick System starts at 0, not 1 if (SDL_WasInit(SDL_INIT_JOYSTICK) == 0) { if (SDL_InitSubSystem(SDL_INIT_JOYSTICK) != -1) - joyname = SDL_JoystickName(joyindex); + { + tempname = SDL_JoystickNameForIndex(joyindex); + if (tempname) + { + templen = strlen(tempname); + joyname = malloc(templen*sizeof(char)); + strcpy(joyname, tempname); + } + } SDL_QuitSubSystem(SDL_INIT_JOYSTICK); } else - joyname = SDL_JoystickName(joyindex); + { + tempname = SDL_JoystickNameForIndex(joyindex); + if (tempname) + { + templen = strlen(tempname); + joyname = malloc(templen*sizeof(char)); + strcpy(joyname, tempname); + } + } return joyname; } From d8e70c32e068f055cfe98d2acaf78152c4bb249b Mon Sep 17 00:00:00 2001 From: mazmazz Date: Mon, 3 Dec 2018 05:39:10 -0500 Subject: [PATCH 2/3] Remove console messages for joynames --- src/m_menu.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/m_menu.c b/src/m_menu.c index 4b65303b..f6eb705f 100644 --- a/src/m_menu.c +++ b/src/m_menu.c @@ -6736,13 +6736,9 @@ static void M_SetupJoystickMenu(INT32 choice) for (i = 1; i < 8; i++) { if (i <= n && (I_GetJoyName(i)) != NULL) - { strncpy(joystickInfo[i], I_GetJoyName(i), 28); - CONS_Printf("%s\n", joystickInfo[i]); - } else strcpy(joystickInfo[i], joyNA); - CONS_Printf("%s\n", joystickInfo[i]); } M_SetupNextMenu(&OP_JoystickSetDef); From 8851f39b84a147bade43917b9cdb9d469bc9983a Mon Sep 17 00:00:00 2001 From: mazmazz Date: Mon, 3 Dec 2018 12:35:12 -0500 Subject: [PATCH 3/3] Use static joyname instead of malloc --- src/sdl/i_system.c | 16 ++++------------ src/sdl12/i_system.c | 16 ++++------------ 2 files changed, 8 insertions(+), 24 deletions(-) diff --git a/src/sdl/i_system.c b/src/sdl/i_system.c index 905bec09..68ebc5e9 100644 --- a/src/sdl/i_system.c +++ b/src/sdl/i_system.c @@ -1453,11 +1453,11 @@ INT32 I_NumJoys(void) return numjoy; } +static char joyname[255]; // MAX_PATH; joystick name is straight from the driver + const char *I_GetJoyName(INT32 joyindex) { const char *tempname = NULL; - size_t templen; - char *joyname = NULL; joyindex--; //SDL's Joystick System starts at 0, not 1 if (SDL_WasInit(SDL_INIT_JOYSTICK) == 0) { @@ -1465,11 +1465,7 @@ const char *I_GetJoyName(INT32 joyindex) { tempname = SDL_JoystickNameForIndex(joyindex); if (tempname) - { - templen = strlen(tempname); - joyname = malloc(templen*sizeof(char)); - strcpy(joyname, tempname); - } + strncpy(joyname, tempname, 255); } SDL_QuitSubSystem(SDL_INIT_JOYSTICK); } @@ -1477,11 +1473,7 @@ const char *I_GetJoyName(INT32 joyindex) { tempname = SDL_JoystickNameForIndex(joyindex); if (tempname) - { - templen = strlen(tempname); - joyname = malloc(templen*sizeof(char)); - strcpy(joyname, tempname); - } + strncpy(joyname, tempname, 255); } return joyname; } diff --git a/src/sdl12/i_system.c b/src/sdl12/i_system.c index c4dd96f8..10fbc50e 100644 --- a/src/sdl12/i_system.c +++ b/src/sdl12/i_system.c @@ -1575,11 +1575,11 @@ INT32 I_NumJoys(void) return numjoy; } +static char joyname[255]; // MAX_PATH; joystick name is straight from the driver + const char *I_GetJoyName(INT32 joyindex) { const char *tempname = NULL; - size_t templen; - char *joyname = NULL; joyindex--; //SDL's Joystick System starts at 0, not 1 if (SDL_WasInit(SDL_INIT_JOYSTICK) == 0) { @@ -1587,11 +1587,7 @@ const char *I_GetJoyName(INT32 joyindex) { tempname = SDL_JoystickNameForIndex(joyindex); if (tempname) - { - templen = strlen(tempname); - joyname = malloc(templen*sizeof(char)); - strcpy(joyname, tempname); - } + strncpy(joyname, tempname, 255); } SDL_QuitSubSystem(SDL_INIT_JOYSTICK); } @@ -1599,11 +1595,7 @@ const char *I_GetJoyName(INT32 joyindex) { tempname = SDL_JoystickNameForIndex(joyindex); if (tempname) - { - templen = strlen(tempname); - joyname = malloc(templen*sizeof(char)); - strcpy(joyname, tempname); - } + strncpy(joyname, tempname, 255); } return joyname; }