Build: kill GCC 7's implicit-fallthrough warning

This commit is contained in:
Alam Ed Arias 2017-09-28 09:39:47 -04:00
parent 55f377ba3d
commit 2ccd397d11
15 changed files with 58 additions and 17 deletions

View File

@ -412,7 +412,7 @@ static Instruction symbexec (const Proto *pt, int lastpc, int reg) {
case OP_FORLOOP: case OP_FORLOOP:
case OP_FORPREP: case OP_FORPREP:
checkreg(pt, a+3); checkreg(pt, a+3);
/* go through */ /* FALLTHRU */
case OP_JMP: { case OP_JMP: {
int dest = pc+1+b; int dest = pc+1+b;
/* not full check and jump is forward and do not skip `lastpc'? */ /* not full check and jump is forward and do not skip `lastpc'? */

View File

@ -311,6 +311,7 @@ static void read_string (LexState *ls, int del, SemInfo *seminfo) {
ls->lookahead.token = TK_CONCAT; ls->lookahead.token = TK_CONCAT;
return; return;
} }
/* FALLTHRU */
default: { default: {
if (!isdigit(ls->current)) if (!isdigit(ls->current))
save_and_next(ls); /* handles \\, \", \', and \? */ save_and_next(ls); /* handles \\, \", \', and \? */
@ -340,7 +341,8 @@ static void read_string (LexState *ls, int del, SemInfo *seminfo) {
}; };
switch (i) { switch (i) {
case 4: save( ls, (c>>8) & 0xff ); // pass-through.. case 4: save( ls, (c>>8) & 0xff );
/* FALLTHRU */
case 2: save( ls, c&0xff ); case 2: save( ls, c&0xff );
break; break;
case 5: case 5:
@ -482,11 +484,13 @@ static int llex (LexState *ls, SemInfo *seminfo) {
else if (sep == -1) return '['; else if (sep == -1) return '[';
else luaX_lexerror(ls, "invalid long string delimiter", TK_STRING); else luaX_lexerror(ls, "invalid long string delimiter", TK_STRING);
} }
/* FALLTHRU */
case '=': { case '=': {
next(ls); next(ls);
if (ls->current != '=') return '='; if (ls->current != '=') return '=';
else { next(ls); return TK_EQ; } else { next(ls); return TK_EQ; }
} }
/* FALLTHRU */
case '<': { case '<': {
next(ls); next(ls);
if (ls->current == '<') { next(ls); return TK_SHL; } if (ls->current == '<') { next(ls); return TK_SHL; }
@ -550,6 +554,7 @@ static int llex (LexState *ls, SemInfo *seminfo) {
ls->current = '"'; /* whacky! */ ls->current = '"'; /* whacky! */
return TK_CONCAT; return TK_CONCAT;
} }
/* FALLTHRU */
default: { default: {
if (isspace(ls->current)) { if (isspace(ls->current)) {
lua_assert(!currIsNewline(ls)); lua_assert(!currIsNewline(ls));

View File

@ -478,6 +478,7 @@ static TValue *newkey (lua_State *L, Table *t, const TValue *key) {
return luaH_getnum(t, k); /* use specialized version */ return luaH_getnum(t, k); /* use specialized version */
/* else go through */ /* else go through */
} }
/* FALLTHRU */
default: { default: {
Node *n = mainposition(t, key); Node *n = mainposition(t, key);
do { /* check whether `key' is somewhere in the chain */ do { /* check whether `key' is somewhere in the chain */

View File

@ -1883,6 +1883,7 @@ static boolean CL_ServerConnectionTicker(boolean viams, const char *tmpsave, tic
break; // exit the case break; // exit the case
cl_mode = CL_ASKJOIN; // don't break case continue to cljoin request now cl_mode = CL_ASKJOIN; // don't break case continue to cljoin request now
/* FALLTHRU */
case CL_ASKJOIN: case CL_ASKJOIN:
CL_LoadServerFiles(); CL_LoadServerFiles();
@ -3605,6 +3606,7 @@ static void HandlePacketFromAwayNode(SINT8 node)
// Do not remove my own server (we have just get a out of order packet) // Do not remove my own server (we have just get a out of order packet)
if (node == servernode) if (node == servernode)
break; break;
/* FALLTHRU */
default: default:
DEBFILE(va("unknown packet received (%d) from unknown host\n",netbuffer->packettype)); DEBFILE(va("unknown packet received (%d) from unknown host\n",netbuffer->packettype));
@ -3761,6 +3763,7 @@ FILESTAMP
break; break;
case PT_TEXTCMD2: // splitscreen special case PT_TEXTCMD2: // splitscreen special
netconsole = nodetoplayer2[node]; netconsole = nodetoplayer2[node];
/* FALLTHRU */
case PT_TEXTCMD: case PT_TEXTCMD:
if (client) if (client)
break; break;

View File

@ -2453,7 +2453,7 @@ static void Got_Teamchange(UINT8 **cp, INT32 playernum)
error = true; error = true;
break; break;
} }
//fall down /* FALLTHRU */
case GT_TAG: case GT_TAG:
switch (NetPacket.packet.newteam) switch (NetPacket.packet.newteam)
{ {

View File

@ -3022,6 +3022,7 @@ static void M_DrawGenericMenu(void)
W_CachePatchName(currentMenu->menuitems[i].patch, PU_CACHE)); W_CachePatchName(currentMenu->menuitems[i].patch, PU_CACHE));
} }
} }
/* FALLTHRU */
case IT_NOTHING: case IT_NOTHING:
case IT_DYBIGSPACE: case IT_DYBIGSPACE:
y += LINEHEIGHT; y += LINEHEIGHT;
@ -3073,6 +3074,7 @@ static void M_DrawGenericMenu(void)
break; break;
case IT_STRING2: case IT_STRING2:
V_DrawString(x, y, 0, currentMenu->menuitems[i].text); V_DrawString(x, y, 0, currentMenu->menuitems[i].text);
/* FALLTHRU */
case IT_DYLITLSPACE: case IT_DYLITLSPACE:
y += SMALLLINEHEIGHT; y += SMALLLINEHEIGHT;
break; break;
@ -3085,6 +3087,7 @@ static void M_DrawGenericMenu(void)
case IT_TRANSTEXT: case IT_TRANSTEXT:
if (currentMenu->menuitems[i].alphaKey) if (currentMenu->menuitems[i].alphaKey)
y = currentMenu->y+currentMenu->menuitems[i].alphaKey; y = currentMenu->y+currentMenu->menuitems[i].alphaKey;
/* FALLTHRU */
case IT_TRANSTEXT2: case IT_TRANSTEXT2:
V_DrawString(x, y, V_TRANSLUCENT, currentMenu->menuitems[i].text); V_DrawString(x, y, V_TRANSLUCENT, currentMenu->menuitems[i].text);
y += SMALLLINEHEIGHT; y += SMALLLINEHEIGHT;
@ -3297,6 +3300,7 @@ static void M_DrawCenteredMenu(void)
W_CachePatchName(currentMenu->menuitems[i].patch, PU_CACHE)); W_CachePatchName(currentMenu->menuitems[i].patch, PU_CACHE));
} }
} }
/* FALLTHRU */
case IT_NOTHING: case IT_NOTHING:
case IT_DYBIGSPACE: case IT_DYBIGSPACE:
y += LINEHEIGHT; y += LINEHEIGHT;
@ -3347,6 +3351,7 @@ static void M_DrawCenteredMenu(void)
break; break;
case IT_STRING2: case IT_STRING2:
V_DrawCenteredString(x, y, 0, currentMenu->menuitems[i].text); V_DrawCenteredString(x, y, 0, currentMenu->menuitems[i].text);
/* FALLTHRU */
case IT_DYLITLSPACE: case IT_DYLITLSPACE:
y += SMALLLINEHEIGHT; y += SMALLLINEHEIGHT;
break; break;

View File

@ -79,7 +79,7 @@ void T_MoveCeiling(ceiling_t *ceiling)
P_LinedefExecute((INT16)(ceiling->texture + INT16_MAX + 2), NULL, NULL); P_LinedefExecute((INT16)(ceiling->texture + INT16_MAX + 2), NULL, NULL);
if (ceiling->texture > -1) // flat changing if (ceiling->texture > -1) // flat changing
ceiling->sector->ceilingpic = ceiling->texture; ceiling->sector->ceilingpic = ceiling->texture;
// don't break /* FALLTHRU */
case raiseToHighest: case raiseToHighest:
// case raiseCeilingByLine: // case raiseCeilingByLine:
case moveCeilingByFrontTexture: case moveCeilingByFrontTexture:
@ -182,6 +182,7 @@ void T_MoveCeiling(ceiling_t *ceiling)
// except generalized ones, reset speed, start back up // except generalized ones, reset speed, start back up
case crushAndRaise: case crushAndRaise:
ceiling->speed = CEILSPEED; ceiling->speed = CEILSPEED;
/* FALLTHRU */
case fastCrushAndRaise: case fastCrushAndRaise:
ceiling->direction = 1; ceiling->direction = 1;
break; break;
@ -200,6 +201,7 @@ void T_MoveCeiling(ceiling_t *ceiling)
if (ceiling->texture > -1) // flat changing if (ceiling->texture > -1) // flat changing
ceiling->sector->ceilingpic = ceiling->texture; ceiling->sector->ceilingpic = ceiling->texture;
// don't break // don't break
/* FALLTHRU */
// in all other cases, just remove the active ceiling // in all other cases, just remove the active ceiling
case lowerAndCrush: case lowerAndCrush:
@ -427,6 +429,7 @@ INT32 EV_DoCeiling(line_t *line, ceiling_e type)
case crushAndRaise: case crushAndRaise:
ceiling->crush = true; ceiling->crush = true;
ceiling->topheight = sec->ceilingheight; ceiling->topheight = sec->ceilingheight;
/* FALLTHRU */
case lowerAndCrush: case lowerAndCrush:
ceiling->bottomheight = sec->floorheight; ceiling->bottomheight = sec->floorheight;
ceiling->bottomheight += 4*FRACUNIT; ceiling->bottomheight += 4*FRACUNIT;

View File

@ -6169,7 +6169,7 @@ void A_Boss7Chase(mobj_t *actor)
break; break;
} }
actor->threshold++; actor->threshold++;
// fall into... /* FALLTHRU */
case 1: // Chaingun Goop case 1: // Chaingun Goop
A_FaceTarget(actor); A_FaceTarget(actor);
P_SetMobjState(actor, S_BLACKEGG_SHOOT1); P_SetMobjState(actor, S_BLACKEGG_SHOOT1);

View File

@ -312,6 +312,7 @@ void T_MoveFloor(floormove_t *movefloor)
case moveFloorByFrontSector: case moveFloorByFrontSector:
if (movefloor->texture < -1) // chained linedef executing if (movefloor->texture < -1) // chained linedef executing
P_LinedefExecute((INT16)(movefloor->texture + INT16_MAX + 2), NULL, NULL); P_LinedefExecute((INT16)(movefloor->texture + INT16_MAX + 2), NULL, NULL);
/* FALLTHRU */
case instantMoveFloorByFrontSector: case instantMoveFloorByFrontSector:
if (movefloor->texture > -1) // flat changing if (movefloor->texture > -1) // flat changing
movefloor->sector->floorpic = movefloor->texture; movefloor->sector->floorpic = movefloor->texture;
@ -360,6 +361,7 @@ void T_MoveFloor(floormove_t *movefloor)
case moveFloorByFrontSector: case moveFloorByFrontSector:
if (movefloor->texture < -1) // chained linedef executing if (movefloor->texture < -1) // chained linedef executing
P_LinedefExecute((INT16)(movefloor->texture + INT16_MAX + 2), NULL, NULL); P_LinedefExecute((INT16)(movefloor->texture + INT16_MAX + 2), NULL, NULL);
/* FALLTHRU */
case instantMoveFloorByFrontSector: case instantMoveFloorByFrontSector:
if (movefloor->texture > -1) // flat changing if (movefloor->texture > -1) // flat changing
movefloor->sector->floorpic = movefloor->texture; movefloor->sector->floorpic = movefloor->texture;

View File

@ -383,9 +383,11 @@ void P_TouchSpecialThing(mobj_t *special, mobj_t *toucher, boolean heightcheck)
case MT_REDTEAMRING: case MT_REDTEAMRING:
if (player->ctfteam != 1) if (player->ctfteam != 1)
return; return;
/* FALLTHRU */
case MT_BLUETEAMRING: // Yes, I'm lazy. Oh well, deal with it. case MT_BLUETEAMRING: // Yes, I'm lazy. Oh well, deal with it.
if (special->type == MT_BLUETEAMRING && player->ctfteam != 2) if (special->type == MT_BLUETEAMRING && player->ctfteam != 2)
return; return;
/* FALLTHRU */
case MT_RING: case MT_RING:
case MT_FLINGRING: case MT_FLINGRING:
if (!(P_CanPickupItem(player, false))) if (!(P_CanPickupItem(player, false)))
@ -3127,7 +3129,7 @@ boolean P_DamageMobj(mobj_t *target, mobj_t *inflictor, mobj_t *source, INT32 da
P_SetMobjState(target, target->info->meleestate); // go to pinch pain state P_SetMobjState(target, target->info->meleestate); // go to pinch pain state
break; break;
} }
// fallthrough /* FALLTHRU */
default: default:
P_SetMobjState(target, target->info->painstate); P_SetMobjState(target, target->info->painstate);
break; break;

View File

@ -7138,7 +7138,7 @@ void P_MobjThinker(mobj_t *mobj)
mobj->z = mobj->ceilingz - mobj->height; mobj->z = mobj->ceilingz - mobj->height;
else else
mobj->z = mobj->floorz; mobj->z = mobj->floorz;
// THERE IS NO BREAK HERE ON PURPOSE /* FALLTHRU */
default: default:
// check mobj against possible water content, before movement code // check mobj against possible water content, before movement code
P_MobjCheckWater(mobj); P_MobjCheckWater(mobj);
@ -8185,6 +8185,7 @@ void P_PrecipitationEffects(void)
{ {
case PRECIP_RAIN: // no lightning or thunder whatsoever case PRECIP_RAIN: // no lightning or thunder whatsoever
sounds_thunder = false; sounds_thunder = false;
/* FALLTHRU */
case PRECIP_STORM_NOSTRIKES: // no lightning strikes specifically case PRECIP_STORM_NOSTRIKES: // no lightning strikes specifically
effects_lightning = false; effects_lightning = false;
break; break;

View File

@ -3625,6 +3625,7 @@ void P_ProcessSpecialSector(player_t *player, sector_t *sector, sector_t *rovers
goto DoneSection2; goto DoneSection2;
} }
} }
/* FALLTHRU */
case 4: // Linedef executor that doesn't require touching floor case 4: // Linedef executor that doesn't require touching floor
case 5: // Linedef executor case 5: // Linedef executor
case 6: // Linedef executor (7 Emeralds) case 6: // Linedef executor (7 Emeralds)
@ -4632,6 +4633,8 @@ static void P_RunSpecialSectorCheck(player_t *player, sector_t *sector)
// requires touching floor. // requires touching floor.
break; break;
} }
/* FALLTHRU */
case 1: // Starpost activator case 1: // Starpost activator
case 5: // Fan sector case 5: // Fan sector
case 6: // Super Sonic Transform case 6: // Super Sonic Transform
@ -5711,6 +5714,8 @@ void P_SpawnSpecials(INT32 fromnetsave)
EV_DoFloor(&lines[i], bounceFloor); EV_DoFloor(&lines[i], bounceFloor);
if (lines[i].special == 54) if (lines[i].special == 54)
break; break;
/* FALLTHRU */
case 55: // New super cool and awesome moving ceiling type case 55: // New super cool and awesome moving ceiling type
if (lines[i].backsector) if (lines[i].backsector)
EV_DoCeiling(&lines[i], bounceCeiling); EV_DoCeiling(&lines[i], bounceCeiling);
@ -5723,6 +5728,7 @@ void P_SpawnSpecials(INT32 fromnetsave)
if (lines[i].special == 57) if (lines[i].special == 57)
break; //only move the floor break; //only move the floor
/* FALLTHRU */
case 58: // New super cool and awesome moving ceiling crush type case 58: // New super cool and awesome moving ceiling crush type
if (lines[i].backsector) if (lines[i].backsector)
@ -6828,6 +6834,7 @@ static void P_SpawnScrollers(void)
Add_Scroller(sc_ceiling, -dx, dy, control, s, accel, l->flags & ML_NOCLIMB); Add_Scroller(sc_ceiling, -dx, dy, control, s, accel, l->flags & ML_NOCLIMB);
if (special != 533) if (special != 533)
break; break;
/* FALLTHRU */
case 523: // carry objects on ceiling case 523: // carry objects on ceiling
dx = FixedMul(dx, CARRYFACTOR); dx = FixedMul(dx, CARRYFACTOR);
@ -6842,6 +6849,7 @@ static void P_SpawnScrollers(void)
Add_Scroller(sc_floor, -dx, dy, control, s, accel, l->flags & ML_NOCLIMB); Add_Scroller(sc_floor, -dx, dy, control, s, accel, l->flags & ML_NOCLIMB);
if (special != 530) if (special != 530)
break; break;
/* FALLTHRU */
case 520: // carry objects on floor case 520: // carry objects on floor
dx = FixedMul(dx, CARRYFACTOR); dx = FixedMul(dx, CARRYFACTOR);

View File

@ -941,6 +941,7 @@ static inline boolean I_SkipFrame(void)
case GS_LEVEL: case GS_LEVEL:
if (!paused) if (!paused)
return false; return false;
/* FALLTHRU */
case GS_TIMEATTACK: case GS_TIMEATTACK:
case GS_WAITINGPLAYERS: case GS_WAITINGPLAYERS:
return skip; // Skip odd frames return skip; // Skip odd frames

View File

@ -1083,6 +1083,7 @@ char *V_WordWrap(INT32 x, INT32 w, INT32 option, const char *string)
{ {
case V_MONOSPACE: case V_MONOSPACE:
spacewidth = 8; spacewidth = 8;
/* FALLTHRU */
case V_OLDSPACING: case V_OLDSPACING:
charwidth = 8; charwidth = 8;
break; break;
@ -1160,6 +1161,7 @@ void V_DrawString(INT32 x, INT32 y, INT32 option, const char *string)
{ {
case V_MONOSPACE: case V_MONOSPACE:
spacewidth = 8; spacewidth = 8;
/* FALLTHRU */
case V_OLDSPACING: case V_OLDSPACING:
charwidth = 8; charwidth = 8;
break; break;
@ -1269,6 +1271,7 @@ void V_DrawSmallString(INT32 x, INT32 y, INT32 option, const char *string)
{ {
case V_MONOSPACE: case V_MONOSPACE:
spacewidth = 4; spacewidth = 4;
/* FALLTHRU */
case V_OLDSPACING: case V_OLDSPACING:
charwidth = 4; charwidth = 4;
break; break;
@ -1370,6 +1373,7 @@ void V_DrawThinString(INT32 x, INT32 y, INT32 option, const char *string)
{ {
case V_MONOSPACE: case V_MONOSPACE:
spacewidth = 5; spacewidth = 5;
/* FALLTHRU */
case V_OLDSPACING: case V_OLDSPACING:
charwidth = 5; charwidth = 5;
break; break;
@ -1463,6 +1467,7 @@ void V_DrawStringAtFixed(fixed_t x, fixed_t y, INT32 option, const char *string)
{ {
case V_MONOSPACE: case V_MONOSPACE:
spacewidth = 8; spacewidth = 8;
/* FALLTHRU */
case V_OLDSPACING: case V_OLDSPACING:
charwidth = 8; charwidth = 8;
break; break;
@ -1747,6 +1752,7 @@ INT32 V_StringWidth(const char *string, INT32 option)
{ {
case V_MONOSPACE: case V_MONOSPACE:
spacewidth = 8; spacewidth = 8;
/* FALLTHRU */
case V_OLDSPACING: case V_OLDSPACING:
charwidth = 8; charwidth = 8;
break; break;
@ -1785,6 +1791,7 @@ INT32 V_SmallStringWidth(const char *string, INT32 option)
{ {
case V_MONOSPACE: case V_MONOSPACE:
spacewidth = 4; spacewidth = 4;
/* FALLTHRU */
case V_OLDSPACING: case V_OLDSPACING:
charwidth = 4; charwidth = 4;
break; break;
@ -1823,6 +1830,7 @@ INT32 V_ThinStringWidth(const char *string, INT32 option)
{ {
case V_MONOSPACE: case V_MONOSPACE:
spacewidth = 5; spacewidth = 5;
/* FALLTHRU */
case V_OLDSPACING: case V_OLDSPACING:
charwidth = 5; charwidth = 5;
break; break;

View File

@ -1004,6 +1004,7 @@ void Y_StartIntermission(void)
// fall back into the coop intermission for now // fall back into the coop intermission for now
intertype = int_coop; intertype = int_coop;
/* FALLTHRU */
case int_coop: // coop or single player, normal level case int_coop: // coop or single player, normal level
{ {
// award time and ring bonuses // award time and ring bonuses
@ -1117,6 +1118,7 @@ void Y_StartIntermission(void)
// fall back into the special stage intermission for now // fall back into the special stage intermission for now
intertype = int_spec; intertype = int_spec;
/* FALLTHRU */
case int_spec: // coop or single player, special stage case int_spec: // coop or single player, special stage
{ {
// Update visitation flags? // Update visitation flags?