From 0cc838bca720a6ebb5a6755deef6a2fc2e61d8bd Mon Sep 17 00:00:00 2001 From: toasterbabe Date: Tue, 9 May 2017 14:17:34 +0100 Subject: [PATCH 1/5] make: *** [../objs/Mingw/Debug/m_menu.o] Error 1 s_sound.c: In function `S_StartCaption': s_sound.c:416: warning: comparison of unsigned expression >= 0 is always true Makefile:770: recipe for target '../objs/Mingw/Debug/s_sound.o' failed make: *** [../objs/Mingw/Debug/s_sound.o] Error 1 --- src/s_sound.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/s_sound.c b/src/s_sound.c index b8cb06075..20b71fce8 100644 --- a/src/s_sound.c +++ b/src/s_sound.c @@ -413,7 +413,7 @@ void S_StartCaption(sfxenum_t sfx_id, INT32 cnum, UINT16 lifespan) return; // check for bogus sound # - I_Assert(sfx_id >= 0); // allows sfx_None; this shouldn't be allowed directly if S_StartCaption is ever exposed to Lua by itself + // I_Assert(sfx_id >= 0); -- allowing sfx_None; this shouldn't be allowed directly if S_StartCaption is ever exposed to Lua by itself I_Assert(sfx_id < NUMSFX); sfx = &S_sfx[sfx_id]; From 378b913e6623252cf0408b80a2b20a0efd8fbe6a Mon Sep 17 00:00:00 2001 From: toasterbabe Date: Tue, 9 May 2017 14:18:45 +0100 Subject: [PATCH 2/5] lua_blockmaplib.c:269:7: no newline at end of file Makefile:770: recipe for target '../objs/Mingw/Debug/lua_blockmaplib.o' failed make: *** [../objs/Mingw/Debug/lua_blockmaplib.o] Error 1 --- src/lua_blockmaplib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lua_blockmaplib.c b/src/lua_blockmaplib.c index d90ef4d67..ccd90f993 100644 --- a/src/lua_blockmaplib.c +++ b/src/lua_blockmaplib.c @@ -266,4 +266,4 @@ int LUA_BlockmapLib(lua_State *L) return 0; } -#endif \ No newline at end of file +#endif From a4b74e7d3fcfc665ee272da0c9946f5754e08e96 Mon Sep 17 00:00:00 2001 From: toasterbabe Date: Tue, 9 May 2017 14:19:54 +0100 Subject: [PATCH 3/5] m_menu.c:1907: error: `M_DrawScreenshotMenu' undeclared here (not in a function) m_menu.c:1907: error: initializer element is not constant m_menu.c:1907: error: (near initialization for `OP_ScreenshotOptionsDef.drawroutine') m_menu.c:9353: warning: 'M_DrawScreenshotMenu' defined but not used Makefile:770: recipe for target '../objs/Mingw/Debug/m_menu.o' failed make: *** [../objs/Mingw/Debug/m_menu.o] Error 1 --- src/m_menu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/m_menu.c b/src/m_menu.c index 68a838760..b7f9e8802 100644 --- a/src/m_menu.c +++ b/src/m_menu.c @@ -358,6 +358,7 @@ static void M_DrawMainVideoMenu(void); static void M_DrawVideoMode(void); static void M_DrawColorMenu(void); static void M_DrawSoundMenu(void); +static void M_DrawScreenshotMenu(void); static void M_DrawMonitorToggles(void); #ifdef HWRENDER static void M_OGL_DrawFogMenu(void); From e69b08178f91648e327cff663356fa330f8e7f47 Mon Sep 17 00:00:00 2001 From: toasterbabe Date: Tue, 9 May 2017 14:42:06 +0100 Subject: [PATCH 4/5] p_floor.c: In function `EV_CrumbleChain': p_floor.c:2932: warning: 'widthfactor' might be used uninitialized in this function p_floor.c:2932: warning: 'heightfactor' might be used uninitialized in this function --- src/p_floor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/p_floor.c b/src/p_floor.c index cefdc3d4f..68c3d55b8 100644 --- a/src/p_floor.c +++ b/src/p_floor.c @@ -2929,7 +2929,7 @@ void EV_CrumbleChain(sector_t *sec, ffloor_t *rover) fixed_t leftx, rightx; fixed_t topy, bottomy; fixed_t topz, bottomz; - fixed_t widthfactor, heightfactor; + fixed_t widthfactor = FRACUNIT, heightfactor = FRACUNIT; fixed_t a, b, c; mobjtype_t type = MT_ROCKCRUMBLE1; fixed_t spacing = (32< Date: Tue, 9 May 2017 14:42:23 +0100 Subject: [PATCH 5/5] s_sound.c: In function `S_StartCaption': s_sound.c:409: warning: 'same' might be used uninitialized in this functio --- src/s_sound.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/s_sound.c b/src/s_sound.c index 20b71fce8..2f3b1ae93 100644 --- a/src/s_sound.c +++ b/src/s_sound.c @@ -406,7 +406,7 @@ void S_StopSoundByNum(sfxenum_t sfxnum) void S_StartCaption(sfxenum_t sfx_id, INT32 cnum, UINT16 lifespan) { UINT8 i, set, moveup, start; - boolean same; + boolean same = false; sfxinfo_t *sfx; if (!cv_closedcaptioning.value) // no captions at all