lifning
/
SRB2
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use a pointer for port_name 

Using strcpy is stupid because we don't know how long the argument would be.
There's no need for a buffer anyway.
This commit is contained in:
James R 2019-12-18 15:43:29 -08:00
parent f584b61c93
commit 4e32101289
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/i_tcp.c
View File

@ -209,7 +209,7 @@ static size_t numbans = 0;
static boolean SOCK_bannednode[MAXNETNODES+1]; /// \note do we really need the +1?
static boolean init_tcp_driver = false;
static char port_name[8] = DEFAULTPORT;
static const char *port_name = DEFAULTPORT;
#ifndef NONET
@ -1431,10 +1431,11 @@ boolean I_InitTcpNetwork(void)
// Combined -udpport and -clientport into -port
// As it was really redundant having two seperate parms that does the same thing
{
if (M_IsNextParm())
strcpy(port_name, M_GetNextParm());
else
strcpy(port_name, "0");
/*
If it's NULL, that's okay! Because then
we'll get a random port from getaddrinfo.
*/
port_name = M_GetNextParm();
}
// parse network game options,